Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macro definition of iodefine_typedef for RZ_A1H #6288

Merged
merged 1 commit into from Mar 15, 2018
Merged

Fix macro definition of iodefine_typedef for RZ_A1H #6288

merged 1 commit into from Mar 15, 2018

Conversation

TomoYamanaka
Copy link
Contributor

@TomoYamanaka TomoYamanaka commented Mar 7, 2018 •
edited by 0xc0170

Description

Regarding RZ_A1H, Since I removed the macro definition accidentally in iodefine_typedef, I fixed the lack of it.

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

0xc0170
0xc0170 reviewed Mar 7, 2018
View reviewed changes
targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_RZ_A1H/device/inc/iodefines/iodefine_typedef.h Outdated
@@ -55,6 +55,11 @@ typedef enum iodefine_byte_select_t
{
R_IO_L = 0, R_IO_H = 1,
R_IO_LL= 0, R_IO_LH = 1, R_IO_HL = 2, R_IO_HH = 3
#if(1) /* mbed */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this #if (1) needed , can we remove it?

@TomoYamanaka
Fix macro definition of iodefine_typedef for RZ_A1H
3183d21 
Regarding RZ_A1H, Since I removed the macro definition accidentally in iodefine_typedef, I fixed the lack of it.
@TomoYamanaka
Copy link
Contributor Author

why is this #if (1) needed , can we remove it?

I modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2018

Thanks looks good, will approve.

One note about PR type, can you please leave it in the first message and fill it accordingly ?

In this case:

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

I edited the first one now

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 7, 2018

Build : SUCCESS

Build number : 1379
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6288/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 7, 2018

Exporter Build : SUCCESS

Build number : 1032
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6288/

@mbed-ci
Copy link

mbed-ci commented Mar 7, 2018

Test : FAILURE

Build number : 1161
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6288/1161

@TomoYamanaka
Copy link
Contributor Author

@0xc0170
Thank you for your advice. I'll be careful from now on.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 8, 2018

Test : SUCCESS

Build number : 1169
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6288/1169

@cmonr cmonr merged commit 69bc68d into ARMmbed:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TomoYamanaka @0xc0170 @mbed-ci @cmonr